Make sure your modules actually work before applying

Submitted by AjK on 11 December 2008 - 11:18pm

Here's a snippet from a recent application...

  1. /**
  2.  * Implementation of hook_menu().
  3.  */
  4. function foo_menu($may_cache) {
  5.   $items = array<();
  6.   if ($may_cache) {
  7.     $items[] = array<(
  8.       'path' => 'admin/settings/foo',
  9.       'title' => t('Foo settings'),
  10.       'callback' => 'system_admin_menu_block',
  11.       'position' => 'right',
  12.       'description' => 'Define Foo Module Settings',
  13.       'acces' => user_access('Access Foo Module'),
  14.     );
  15.  
  16.     $items[] = array<(
  17.       'title' => t('Foo Page'),
  18.       'path' => 'foo_video',
  19.       'callback' => 'foo_page',
  20.       'access' => TRUE,
  21.     );
  22.   }
  23. }

Yes, this really was (bar the altering to foo) submitted in an application. I'm not even going to point out the errors here, they should be obvious. All I am going to say is make sure you've actually tested your own work before applying for a CVS account.

This just makes you look careless. Say no more.


»
»