Drupal CVS reviews
Posts made in this category are based on real reviews made of modules offered as Drupal Contrib modules during the CVS application review process.
Drupal Contrib CVS applications
Submitted by AjK on 9 October 2008 - 2:26pmThe Drupal< site runs a repository and project issue system to allow the distribution are various third party contributed modules.
To gain access< potential new users are required to submit applications that include links to examples of their intended contributions. If the applicant fails to provide a link then it can not be progressed and usually (9 times out of 10) results in an automatic decline.
Give us something to review!
Submitted by AjK on 22 June 2009 - 10:31amA recent number of CVS applications have been supported with a link to a module that provides additional functionality to existing modules.
Although this in itself isn't a problem, a lot of these module are very small (usually less than 250 lines of code). In this case, these modules should realistically seek to add this new feature to the existing module it's extending by way of a feature patch.
Module/theme namespacing issues
Submitted by AjK on 12 December 2008 - 2:05pmHere's a lovely function defined in a module offered for contribution...
- function myTruncate($string, $limit, $break=".", $pad="...") {
- // return with no change if string is shorter than $limit
- // is $break present between $limit and the end of the string?
- }
- }
- return $string;
- }
